Modbus RTU bug + fix

1

Hello, @panos I started to test your modbus RTU implementation, and found some comments in your code that it was untested.
I started testing it, and found that the PLC4X library currently has problems with rtu.[Bug]: Mobus RTU nio event loop · Issue #2124 · apache/plc4x · GitHub , this bug makes it unusable.
I have rewritten the modbusSerialAgent/Protocol to directly use the JserialCom that is allready used in the project, so was not too much effort.
GitHub - Hackerberg43/openremote at fix/modbusRTU

However, before I make a pull request, I wonder if the current rtu implementation might allready have been successfully used in another use case?

2

Hey @Berg, thank you so much for taking a look!

The Modbus RTU agent is untested because we didn’t have a Modbus RTU device I could use for testing. That unfortunately hasn’t changed, and I still cannot use the Modbus RTU agent, and I don’t think we know of a case where the Modbus RTU agent has been used at all.

I’ll try to give it some time and review the code, and see how we can get this merged.

Please make a PR to the main OpenRemote repository and I’ll try to take a look.

Thank you very much for putting in the effort!

3

This topic was automatically closed 90 days after the last reply. New replies are no longer allowed.