Zwave and Rules error java.lang.numberformatexception

Designer 2.5
1

Hi

i am using RRD4 for graphing some values from a multi sensor. Everything was working fine for quite sometime until a few week ago when i noticed the graphing was not working any more.

Unfortunately, I am not able to trace back and see what changes i made that possibly broke this graph. I have not made any changes directly related to this rules file or the rrd4j config.

in order to display the values on the graph, i had to create rules for converting the raw (or i believe they are string values) passed by the zwave multisensor and convert them to integer and i used those as source for the RRD4J graph in the rrd4j config file (attached). The rule files is as follows for converting those raw values from the zwave sensor to integers:

import java.util.*;
import java.lang.Integer;

rule “luminance”
when
Event( source == “MS2lumsensor”, $l : value > 0 )
then
int i = Integer.parseInt($l.toString());
i=i+1;
execute.command (“vsms2lumcom”, i );
end

rule “humidity”
when
Event( source == “MS2humsensor”, $h : value > 0 )
then
int i = Integer.parseInt($h.toString());
i=i+1;
execute.command (“vsmshum2com”, i );
end

rule “temperature”
when
Event( source == “MS2tempFsensor”, $t : value > 0 )
then
int i = Integer.parseInt($t.toString());
i=i+1;
execute.command (“vsmstemp2com”, i );
end

The rule file gets added without errors but on the termin i see the following when the rules seem to triggered:

ERROR 2018-07-02 22:49:07,389 : Error in executing rule : MS2lumsensor:Exception executing consequence for rule “luminance” in org.openremote.controller.protocol: java.lang.NumberFormatException: For input string: “83.44”
Event org.openremote.controller.model.event.CustomState@a6eff23c not processed!
Exception executing consequence for rule “luminance” in org.openremote.controller.protocol: java.lang.NumberFormatException: For input string: “83.44”
at org.drools.core.runtime.rule.impl.DefaultConsequenceExceptionHandler.handleException(DefaultConsequenceExceptionHandler.java:39)
at org.drools.core.common.DefaultAgenda.fireActivation(DefaultAgenda.java:1100)
at org.drools.core.phreak.RuleExecutor.fire(RuleExecutor.java:121)
at org.drools.core.phreak.RuleExecutor.evaluateNetworkAndFire(RuleExecutor.java:74)
at org.drools.core.common.DefaultAgenda.fireNextItem(DefaultAgenda.java:1007)
at org.drools.core.common.DefaultAgenda.fireLoop(DefaultAgenda.java:1350)
at org.drools.core.common.DefaultAgenda.fireAllRules(DefaultAgenda.java:1288)
at org.drools.core.impl.StatefulKnowledgeSessionImpl.internalFireAllRules(StatefulKnowledgeSessionImpl.java:1306)
at org.drools.core.impl.StatefulKnowledgeSessionImpl.fireAllRules(StatefulKnowledgeSessionImpl.java:1297)
at org.drools.core.impl.StatefulKnowledgeSessionImpl.fireAllRules(StatefulKnowledgeSessionImpl.java:1278)
at org.openremote.controller.statuscache.rules.RuleEngine.push(RuleEngine.java:203)
at org.openremote.controller.statuscache.EventProcessorChain.push(EventProcessorChain.java:196)
at org.openremote.controller.statuscache.StatusCache.update(StatusCache.java:293)
at org.openremote.controller.model.sensor.Sensor.update(Sensor.java:367)
at org.openremote.protocol.zwave.ZWaveCommand.updateSensors(ZWaveCommand.java:587)
at org.openremote.protocol.zwave.model.commandclasses.CCMultiLevelSensor.updateSensorCommand(CCMultiLevelSensor.java:1769)
at org.openremote.protocol.zwave.model.commandclasses.CCMultiLevelSensor.linkSensorCommand(CCMultiLevelSensor.java:1357)
at org.openremote.protocol.zwave.model.ZWaveNode.linkSensorCommand(ZWaveNode.java:858)
at org.openremote.protocol.zwave.model.ZWaveNode.addSensorCommand(ZWaveNode.java:993)
at org.openremote.protocol.zwave.ZWaveCommand.setSensor(ZWaveCommand.java:461)
at org.openremote.controller.model.sensor.Sensor.start(Sensor.java:412)
at org.openremote.controller.deployer.Version20ModelBuilder.buildSensorModel(Version20ModelBuilder.java:718)
at org.openremote.controller.deployer.Version20ModelBuilder.build(Version20ModelBuilder.java:595)
at org.openremote.controller.deployer.AbstractModelBuilder.buildModel(AbstractModelBuilder.java:154)
at org.openremote.controller.service.Deployer.startup(Deployer.java:1060)
at org.openremote.controller.service.Deployer.softRestart(Deployer.java:455)
at org.openremote.controller.service.Deployer$ControllerDefinitionWatch.run(Deployer.java:1642)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.NumberFormatException: For input string: “83.44”
at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
at java.lang.Integer.parseInt(Integer.java:580)
at java.lang.Integer.parseInt(Integer.java:615)
at org.openremote.controller.protocol.Rule_luminance427027631.defaultConsequence(Rule_luminance427027631.java:7)
at org.openremote.controller.protocol.Rule_luminance427027631DefaultConsequenceInvokerGenerated.evaluate(Unknown Source)
at org.openremote.controller.protocol.Rule_luminance427027631DefaultConsequenceInvoker.evaluate(Unknown Source)
at org.drools.core.common.DefaultAgenda.fireActivation(DefaultAgenda.java:1089)

… 26 more
ERROR [Controller Definition File Watcher for Default Deployer]: Error in executing rule : MS2lumsensor:Exception executing consequence for rule “luminance” in org.openremote.controller.protocol: java.lang.NumberFormatException: For input string: “83.44”
Event org.openremote.controller.model.event.CustomState@a6eff23c not processed!
Exception executing consequence for rule “luminance” in org.openremote.controller.protocol: java.lang.NumberFormatException: For input string: “83.44”
at org.drools.core.runtime.rule.impl.DefaultConsequenceExceptionHandler.handleException(DefaultConsequenceExceptionHandler.java:39)
at org.drools.core.common.DefaultAgenda.fireActivation(DefaultAgenda.java:1100)
at org.drools.core.phreak.RuleExecutor.fire(RuleExecutor.java:121)
at org.drools.core.phreak.RuleExecutor.evaluateNetworkAndFire(RuleExecutor.java:74)
at org.drools.core.common.DefaultAgenda.fireNextItem(DefaultAgenda.java:1007)
at org.drools.core.common.DefaultAgenda.fireLoop(DefaultAgenda.java:1350)
at org.drools.core.common.DefaultAgenda.fireAllRules(DefaultAgenda.java:1288)
at org.drools.core.impl.StatefulKnowledgeSessionImpl.internalFireAllRules(StatefulKnowledgeSessionImpl.java:1306)
at org.drools.core.impl.StatefulKnowledgeSessionImpl.fireAllRules(StatefulKnowledgeSessionImpl.java:1297)
at org.drools.core.impl.StatefulKnowledgeSessionImpl.fireAllRules(StatefulKnowledgeSessionImpl.java:1278)
at org.openremote.controller.statuscache.rules.RuleEngine.push(RuleEngine.java:203)
at org.openremote.controller.statuscache.EventProcessorChain.push(EventProcessorChain.java:196)
at org.openremote.controller.statuscache.StatusCache.update(StatusCache.java:293)
at org.openremote.controller.model.sensor.Sensor.update(Sensor.java:367)
at org.openremote.protocol.zwave.ZWaveCommand.updateSensors(ZWaveCommand.java:587)
at org.openremote.protocol.zwave.model.commandclasses.CCMultiLevelSensor.updateSensorCommand(CCMultiLevelSensor.java:1769)
at org.openremote.protocol.zwave.model.commandclasses.CCMultiLevelSensor.linkSensorCommand(CCMultiLevelSensor.java:1357)
at org.openremote.protocol.zwave.model.ZWaveNode.linkSensorCommand(ZWaveNode.java:858)
at org.openremote.protocol.zwave.model.ZWaveNode.addSensorCommand(ZWaveNode.java:993)
at org.openremote.protocol.zwave.ZWaveCommand.setSensor(ZWaveCommand.java:461)
at org.openremote.controller.model.sensor.Sensor.start(Sensor.java:412)
at org.openremote.controller.deployer.Version20ModelBuilder.buildSensorModel(Version20ModelBuilder.java:718)
at org.openremote.controller.deployer.Version20ModelBuilder.build(Version20ModelBuilder.java:595)
at org.openremote.controller.deployer.AbstractModelBuilder.buildModel(AbstractModelBuilder.java:154)
at org.openremote.controller.service.Deployer.startup(Deployer.java:1060)
at org.openremote.controller.service.Deployer.softRestart(Deployer.java:455)
at org.openremote.controller.service.Deployer$ControllerDefinitionWatch.run(Deployer.java:1642)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.NumberFormatException: For input string: “83.44”
at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
at java.lang.Integer.parseInt(Integer.java:580)
at java.lang.Integer.parseInt(Integer.java:615)
at org.openremote.controller.protocol.Rule_luminance427027631.defaultConsequence(Rule_luminance427027631.java:7)
at org.openremote.controller.protocol.Rule_luminance427027631DefaultConsequenceInvokerGenerated.evaluate(Unknown Source)
at org.openremote.controller.protocol.Rule_luminance427027631DefaultConsequenceInvoker.evaluate(Unknown Source)
at org.drools.core.common.DefaultAgenda.fireActivation(DefaultAgenda.java:1089)
… 26 more
ERROR 2018-07-02 22:49:07,394 : Root Cause:

java.lang.NumberFormatException: For input string: “83.44”
at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
at java.lang.Integer.parseInt(Integer.java:580)
at java.lang.Integer.parseInt(Integer.java:615)
at org.openremote.controller.protocol.Rule_luminance427027631.defaultConsequence(Rule_luminance427027631.java:7)
at org.openremote.controller.protocol.Rule_luminance427027631DefaultConsequenceInvokerGenerated.evaluate(Unknown Source)
at org.openremote.controller.protocol.Rule_luminance427027631DefaultConsequenceInvoker.evaluate(Unknown Source)
at org.drools.core.common.DefaultAgenda.fireActivation(DefaultAgenda.java:1089)
at org.drools.core.phreak.RuleExecutor.fire(RuleExecutor.java:121)
at org.drools.core.phreak.RuleExecutor.evaluateNetworkAndFire(RuleExecutor.java:74)
at org.drools.core.common.DefaultAgenda.fireNextItem(DefaultAgenda.java:1007)
at org.drools.core.common.DefaultAgenda.fireLoop(DefaultAgenda.java:1350)
at org.drools.core.common.DefaultAgenda.fireAllRules(DefaultAgenda.java:1288)
at org.drools.core.impl.StatefulKnowledgeSessionImpl.internalFireAllRules(StatefulKnowledgeSessionImpl.java:1306)
at org.drools.core.impl.StatefulKnowledgeSessionImpl.fireAllRules(StatefulKnowledgeSessionImpl.java:1297)
at org.drools.core.impl.StatefulKnowledgeSessionImpl.fireAllRules(StatefulKnowledgeSessionImpl.java:1278)
at org.openremote.controller.statuscache.rules.RuleEngine.push(RuleEngine.java:203)
at org.openremote.controller.statuscache.EventProcessorChain.push(EventProcessorChain.java:196)
at org.openremote.controller.statuscache.StatusCache.update(StatusCache.java:293)
at org.openremote.controller.model.sensor.Sensor.update(Sensor.java:367)
at org.openremote.protocol.zwave.ZWaveCommand.updateSensors(ZWaveCommand.java:587)
at org.openremote.protocol.zwave.model.commandclasses.CCMultiLevelSensor.updateSensorCommand(CCMultiLevelSensor.java:1769)
at org.openremote.protocol.zwave.model.commandclasses.CCMultiLevelSensor.linkSensorCommand(CCMultiLevelSensor.java:1357)
at org.openremote.protocol.zwave.model.ZWaveNode.linkSensorCommand(ZWaveNode.java:858)
at org.openremote.protocol.zwave.model.ZWaveNode.addSensorCommand(ZWaveNode.java:993)
at org.openremote.protocol.zwave.ZWaveCommand.setSensor(ZWaveCommand.java:461)
at org.openremote.controller.model.sensor.Sensor.start(Sensor.java:412)
at org.openremote.controller.deployer.Version20ModelBuilder.buildSensorModel(Version20ModelBuilder.java:718)
at org.openremote.controller.deployer.Version20ModelBuilder.build(Version20ModelBuilder.java:595)
at org.openremote.controller.deployer.AbstractModelBuilder.buildModel(AbstractModelBuilder.java:154)
at org.openremote.controller.service.Deployer.startup(Deployer.java:1060)
at org.openremote.controller.service.Deployer.softRestart(Deployer.java:455)
at org.openremote.controller.service.Deployer$ControllerDefinitionWatch.run(Deployer.java:1642)
at java.lang.Thread.run(Thread.java:745)
ERROR [Controller Definition File Watcher for Default Deployer]: Root Cause:

rrd4j-config.xml (2.16 KB)

2

From errors it is clear that you have number format exception and the command which drives your graphs is not executed. The reason for the error is that you are trying to parse an integer while the input string contains float number. Therefore, instead Integer.parseInt() use Double.parseDouble() function. Better yet encapsulate it with try{}except{} block like this:

double d;

try{

d = Double.parseDouble($l.toString());

} catch (NumberFormatException e) {

d = 0.0;

}

Kind regards,

Michal

3

Hi Michael,

i tried using it in the rules as you have suggested above but now the rules files is not getting included with following errors as below. I wond if it is related to the changes made in the zwave 3.3.0 as per the thread below. I think my original rule stopped working after i updated the Zwave file to 3.3.0

https://groups.google.com/forum/#!searchin/openremotecommunity/zwave$20integer|sort:date/openremotecommunity/x4KZlBOkckA/NSxI25lpCQAJ

Rule:

package org.openremote.controller.protocol

global org.openremote.controller.statuscache.CommandFacade execute;
global org.openremote.controller.statuscache.SwitchFacade switches;

import java.util.*;
import java.lang.Integer;

rule “luminance”
when
Event( source == “MS2lumsensor”, $l : value > 0 )
then
//double i = Double.parseDouble($l.toString());
//i=i+1;
double d;
try{
d = Double.parseDouble($l.toString());
} catch (NumberFormatException e) {
d = 0.0;
}

execute.command (“vsms2lumcom”, d );
end

rule “humidity”
when
Event( source == “MS2humsensor”, $h : value > 0 )
then
//double i = Double.parseDouble($h.toString());
//i=i+1;
try{
d = Double.parseDouble($h.toString());
} catch (NumberFormatException e) {
d = 0.0;
}

execute.command (“vsmshum2com”, d );
end

rule “temperature”
when
Event( source == “MS2tempFsensor”, $t : value > 0 )
then
//double i = Double.parseDouble($t.toString());
//i=i+1;
try{
d = Double.parseDouble($t.toString());
} catch (NumberFormatException e) {
d = 0.0;
}
execute.command (“vsmstemp2com”, d );
end

ERRORS:

ERROR [main]: Unable to build KieBaseModel:OpenRemoteKBase
Rule Compilation error : [Rule name=‘luminance’]
org/openremote/controller/protocol/Rule_luminance882919569.java (16:745) : The method command(String, String) in the type CommandFacade is not applicable for the arguments (String, double)

Rule Compilation error : [Rule name=‘humidity’]
org/openremote/controller/protocol/Rule_humidity127941601.java (10:627) : d cannot be resolved to a variable
org/openremote/controller/protocol/Rule_humidity127941601.java (12:708) : d cannot be resolved to a variable
org/openremote/controller/protocol/Rule_humidity127941601.java (15:756) : d cannot be resolved to a variable

Rule Compilation error : [Rule name=‘temperature’]
org/openremote/controller/protocol/Rule_temperature1602332535.java (10:631) : d cannot be resolved to a variable
org/openremote/controller/protocol/Rule_temperature1602332535.java (12:712) : d cannot be resolved to a variable
org/openremote/controller/protocol/Rule_temperature1602332535.java (14:759) : d cannot be resolved to a variable

ERROR 2019-03-16 01:03:19,123 : Rule definition ‘graph multisensor.drl’ could not be deployed. See errors below.
ERROR [main]: Rule definition ‘graph multisensor.drl’ could not be deployed. See errors below.
ERROR 2019-03-16 01:03:19,124 : Rule Compilation error The method command(String, String) in the type CommandFacade is not applicable for the arguments (String, double)
ERROR [main]: Rule Compilation error The method command(String, String) in the type CommandFacade is not applicable for the arguments (String, double)
ERROR 2019-03-16 01:03:19,125 : Rule Compilation error d cannot be resolved to a variable
d cannot be resolved to a variable
d cannot be resolved to a variable
ERROR [main]: Rule Compilation error d cannot be resolved to a variable
d cannot be resolved to a variable
d cannot be resolved to a variable
ERROR 2019-03-16 01:03:19,126 : Rule Compilation error d cannot be resolved to a variable
d cannot be resolved to a variable
d cannot be resolved to a variable
ERROR [main]: Rule Compilation error d cannot be resolved to a variable
d cannot be resolved to a variable
d cannot be resolved to a variable

4

i tried adding import java.lang.Double; to see if it helps but no luck.

5

I followed some instructions at this link below and add string.format (".%3f, which seems to successfully add the rules fule without errors but i am wondering if it will work for the graphing which i think requires a number instead of a string for plotting

https://openremote.github.io/archive-dotorg/forums/rules%20and%20cron%20variables.html

6

Hi,

The errors given by compiler explain it all.

In the rule “luminance” and all others you need to convert the second argument to a String as command() expects two strings as arguments, just like in my old blog post http://simpleremote.nl/2013/05/22/temperature-sensors-calibration/

In rules “humidity” and “temperature” you’ve forgot to declare d, look at your “luminance” rule where it is declared.

Kind regards,

Michal

7

What graphing are you referring to? If you are using emoncms.org they it uses API where sending numbers as strings is OK.

8

I have thought of switching over to Emoncms but currently i am using RRD4J.

however for now after i let this running overnight with the changes to rules as per the previous post, i am not seeing any values in graph since July of last year which is when it stopped working (i think this would be when i changed to zwave 3.3.0. because prior to that the raw values were not showing any decimal and were integers.

Further the virtual sensors are displaying 0 on the UI panel so looks like the rule is not transferring values over from actual sensors to the virtual sensors.

i have attached document with screenshot.

when i look at the drools log file, it appears that the rule is getting triggered

DEBUG 2019-03-16 10:11:50,562 (Drools): rule “temperature” // (package org.openremote.controller.protocol)
Declarations
Declaration: “$t: 56.3”
LHS objects(antecedents)
Class: “CustomState”
Fields:
Event Name: “MS2tempFsensor”
Event Value: “56.3”

DEBUG 2019-03-16 10:11:50,651 (Drools): rule “humidity” // (package org.openremote.controller.protocol)
Declarations
Declaration: “$h: 37.5”
LHS objects(antecedents)
Class: “CustomState”
Fields:
Event Name: “MS2humsensor”
Event Value: “37.5”

DEBUG 2019-03-16 10:11:50,738 (Drools): rule “luminance” // (package org.openremote.controller.protocol)
Declarations
Declaration: “$l: 48.43”
LHS objects(antecedents)
Class: “CustomState”
Fields:
Event Name: “MS2lumsensor”
Event Value: “48.43”

virtual sensor values.docx (150 KB)

9

IMHO you have problems with conversion to doubles. Because this code is in try{}catch(){} block you don’t see exceptions in the log. Try to do parseDouble outside the try{} and see if there are any errors.

10

I’m not expert in rrd4j, but obviously it’s the problem in this case as you see the changing sensor value. Try to simplify the graph, remove AVERAGE functions, btw why you have 5 definitions?

Kind regards,
Michal Rutka

11

Thanks Michal. Although I can't still figure out why the parse double is not working, I was able to get the graph working. I noticed it takes 10 mins or so before the values start showing up after restarting the controller.

Also because of averaging, I had to really zoom in to within a day to see the graph.

All my sensors were custom sensors. I changed them to level sensors after which they did not show decimal values and I used parse integer which seems to work. I will do a little more testing and post my working rrd4j config file and the rules file for future reference by others.

I am still interested in trying emoncms. The instructions for it don't seem complete or they may be for a previous version. I will start a new discussion to ask for some additional help on it.

12

Michal,

i have another issue, you wrote a scipt in the past to remeber the values of the sensors > https://www.simpleremote.nl/tag/rules/

it worked perfectly untill i installed the new controller, probably drools has also a new version. ive got this error:

error:

ERROR 2019-11-07 13:37:10,497 : Rule definition ‘a_startup_rules.drl’ could not be deployed. See errors below.
ERROR 2019-11-07 13:37:10,498 : [ERR 102] Line 48:2 mismatched input ‘Event’ in rule “Init values” in pattern
ERROR 2019-11-07 13:37:10,498 : [ERR 102] Line 49:2 mismatched input ‘Event’ in rule “Init values”

which refers to these lines:

Event($s:source matches “^GV.", value=="")
Event($s:source matches "^GV.”, value==“status”)

do you know how to solve this one?

thnx